Add the lack of proper gamut mapping in OKLch and Oklab. The browser support is thus only parial. #26841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…support is thus only parial.
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The current browser implementation of gamut mapping is buggy and not spec compliant. This has accessibility ramifications (the spec ensures that color contrast is preserved, even if a color is beyond what a user can display, but browser don't respect that invariant in their implementation).
Test results and supporting details
Visit https://vasilis.nl/dingen/bugs/oklch.html
The squares should be white and black per spec, they aren't in any browser.
Related issues
This fixes #26838